Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify that get_floor_normal() does not return the surface normal #90254

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Specify that get_floor_normal() does not return the surface normal #90254

merged 1 commit into from
Apr 8, 2024

Conversation

Gamepro5
Copy link
Contributor

@Gamepro5 Gamepro5 commented Apr 5, 2024

Specified that get_floor_normal() does not return the surface normal, but rather the collision normal.

Also see godotengine/godot-proposals#8324

@Gamepro5 Gamepro5 requested a review from a team as a code owner April 5, 2024 10:13
@AThousandShips AThousandShips changed the title Specified that get_floor_normal() does not return the surface normal Specify that get_floor_normal() does not return the surface normal Apr 5, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Apr 5, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 6, 2024
@akien-mga akien-mga changed the title Specify that get_floor_normal() does not return the surface normal Specify that get_floor_normal() does not return the surface normal Apr 6, 2024
@akien-mga
Copy link
Member

@Gamepro5 Would you be able to rebase on latest master to fix CI? The error is not related to this PR but was fixed later. See https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase for instructions.

@akien-mga akien-mga merged commit 1aeb7b9 into godotengine:master Apr 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Gamepro5 Gamepro5 mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:physics
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Gamepro5 @akien-mga @mhilbrunner @smix8 @AThousandShips