Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify UndoRedo MergeMode and add_*_reference docs #90263

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Jordyfel
Copy link
Contributor

@Jordyfel Jordyfel commented Apr 5, 2024

Clarifies parts of the docs which I had trouble understanding when using the class.

@Jordyfel Jordyfel requested a review from a team as a code owner April 5, 2024 13:46
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the added code comments are redundant, but the rewording is correct.

@Jordyfel
Copy link
Contributor Author

Jordyfel commented Apr 5, 2024

Not sure about makes/merges, made it as it was before. Removed the comments

@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Apr 5, 2024
@akien-mga akien-mga merged commit 8bbb027 into godotengine:master Apr 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Jordyfel Jordyfel deleted the undo-redo-doc branch April 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants