SCons: Ensure *all* generated files can be cleaned #90270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #90117, albeit through the exact opposite approach: ensuring all generated files are removed during cleanup. This was achieved by extending the
write_file_if_neededfunction that already attached itself to all generic generation methods (ie: not tied to SCons) with a dedicated SCons environment. The only purpose of this environment is to declare the files as cleanable & to skip any file comparison/creation logic during cleanup.Below compares behavior for an SCons clean followed by git clean. The difference between the two is exclusively the generated files not being present in the PR, having already been successfully cleaned out by SCons.
Live
PR