Add unit tests for OAHashMap
#90313
Merged
Add unit tests for OAHashMap
#90313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Apr 9, 2024
Calinou
reviewed
Apr 9, 2024
Calinou
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Looks good to me, please squash the commits together so we can merge this. See PR workflow for instructions 🙂
Nazarwadim
force-pushed
the
unit_tests_oa_hash_map
branch
from
adf7481 to
0c8e1c6
Compare
Calinou
approved these changes
Apr 10, 2024
|
Thanks! |
vnen
reviewed
Apr 10, 2024
| expected.push_back(Pair<int, int>(0, 12934)); | ||
| expected.push_back(Pair<int, int>(123485, 1238888)); | ||
|
|
||
| int idx = 0; |
There was a problem hiding this comment.
I'm getting a build error here because the idx variable is not used (warning treated as error).
Edit: opened #90496 to fix
There was a problem hiding this comment.
Weird that it wasn't caught on CI. Which compiler and compile option do you use?
There was a problem hiding this comment.
I'm using Clang with dev_mode=yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.