Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set default 2D ruler state #90329

Closed
wants to merge 1 commit into from

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu requested a review from a team as a code owner April 7, 2024 00:45
@akien-mga akien-mga requested a review from KoBeWi April 7, 2024 08:05
@akien-mga akien-mga added this to the 4.x milestone Apr 7, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Apr 7, 2024

As I said already in the proposal, adding an editor setting for something you can toggle once per project is rather meh. Especially when we don't really have other setting like that in the 2D section - everything is stored in editor layout (just like the rulers).

@timothyqiu
Copy link
Member Author

Ruler state is still stored per scene. This editor setting determines the default value for ruler state.

Ruler state is currently not once per project. Whether to show the ruler in a new scene depends on whether the last scene's ruler is shown.

we don't really have other setting like that in the 2D section

I can make default value for other settings also configurable if you want.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 7, 2024

Ruler state is currently not once per project.

Check #74682
We could do the same for rulers.

@timothyqiu
Copy link
Member Author

timothyqiu commented Apr 7, 2024

Check #74682
We could do the same for rulers.

The original proposal want to be able to set "Editor Default", and this is about implementing an auto-remembering "Project Default".

These two features operate at different levels. They can co-exist.

For an auto-remembering project default. Users still have the problem of not being able to disable auto-remembering. That does not solve the problem of the original proposal. Turning on rulers occasionally for one scene breaks the default.

I understand to urge to make the editor feel "smart". However, this should be based on providing full functionality and we should not make choices for the user.

@timothyqiu timothyqiu closed this Apr 7, 2024
@timothyqiu timothyqiu deleted the ruler branch April 7, 2024 11:34
@AThousandShips AThousandShips removed this from the 4.x milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to turn off the 2D Views Ruler guide permanently in Editor Settings
4 participants