-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping imported resource files from export #90365
Conversation
40e6e66
to
398892c
Compare
Thanks! |
I recently made a docs PR to describe the behaviour of Additionally, there is a (possibly extremely minor) issue when skipping scenes in All this got me thinking about whether this PR really is the proper fix for the original issue regarding imported resources not being included in My branch is something I put together in 10 minutes, so I expect there are some issues with it; my intent is just to describe the sort of change I'm proposing. |
tbh this is what I wanted to do at first, I just wasn't sure how and went with a simpler solution. I tested your commit and it correctly skips files, so you can open a PR. |
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
Thanks! I'm working on the new PR now. |
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
This behaviour was introduced in godotengine#90365. This also fixes some inconsistencies in the docs and adds clarification of how the _export_file function works.
Fixes #67844 (it technically resolves the issue in a different way)
Imported resources go through a different code path, so
_export_file()
is not called for them. However they have a separate customization code, so I just allowed to useskip()
when customizing to skip the resource.The only problem is that customization has some cache, so the skip may be ignored if the file was cached and customization does not modify it. But it still at least makes it possible to skip these files, so that's good enough perhaps.