Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect hovered node while dragging #90378

Merged

Conversation

AeioMuch
Copy link
Contributor

@AeioMuch AeioMuch commented Apr 8, 2024

Allow to edit in the inspector the hovered node while dragging other node(s) over it for 1 second in the editor scene tree dock.
This is to avoid having to rely on the workaround and add the missing piece mentioned here : #89406
It also propagate the notification to the inspector dock to highlight the valid properties for the drop

@AeioMuch AeioMuch requested review from a team as code owners April 8, 2024 08:50
@AeioMuch AeioMuch force-pushed the inspect_hovered_node_while_dragging branch 2 times, most recently from 6fdff5a to fb9c8d3 Compare April 8, 2024 09:20
@ajreckof
Copy link
Member

ajreckof commented Apr 8, 2024

Just passing through a node will change the inspector will modify the inspector to edit this node after a few seconds

output.mp4

Moreover I'm wondering why just modify the inspector and not directly select the node in the SceneTreeEditor? this would give better visibility on which node the inspector is and would be a more local solution (don't need a new include)

@AThousandShips AThousandShips added this to the 4.x milestone Apr 8, 2024
@AeioMuch AeioMuch marked this pull request as draft April 9, 2024 05:07
@AeioMuch AeioMuch force-pushed the inspect_hovered_node_while_dragging branch from fb9c8d3 to 8b09861 Compare April 9, 2024 07:01
@AeioMuch AeioMuch marked this pull request as ready for review April 9, 2024 07:45
@AeioMuch AeioMuch requested a review from a team as a code owner April 9, 2024 07:45
@AeioMuch AeioMuch marked this pull request as draft April 9, 2024 14:36
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@AeioMuch AeioMuch force-pushed the inspect_hovered_node_while_dragging branch from 8b09861 to f18f33f Compare April 10, 2024 13:43
@AeioMuch AeioMuch force-pushed the inspect_hovered_node_while_dragging branch from f18f33f to 1a45d2d Compare April 10, 2024 13:47
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@KoBeWi
Copy link
Member

KoBeWi commented Apr 10, 2024

I found a corner-case bug 🤔 When you hover a node and press Escape to cancel dragging, the node will still get inspected afterwards (since the mouse doesn't move). You can use NOTIFICATION_DRAG_END to handle that.

btw why is this still a draft?

@AeioMuch AeioMuch force-pushed the inspect_hovered_node_while_dragging branch from 1a45d2d to 0ba1adf Compare April 10, 2024 15:15
@AeioMuch AeioMuch marked this pull request as ready for review April 10, 2024 15:15
@akien-mga akien-mga removed this from the 4.x milestone Apr 10, 2024
@akien-mga akien-mga added this to the 4.3 milestone Apr 10, 2024
@akien-mga akien-mga merged commit 5bb22d8 into godotengine:master Apr 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AeioMuch AeioMuch deleted the inspect_hovered_node_while_dragging branch April 10, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants