Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RenderingServer.instance_set_transform docs saying it's not global #90396

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Apr 8, 2024

It's equivalent to Node3D.global_transform, not Node3D.transform.

case NOTIFICATION_TRANSFORM_CHANGED: {
Transform3D gt = get_global_transform();
RenderingServer::get_singleton()->instance_set_transform(instance, gt);
} break;

@kleonc kleonc added bug documentation topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 8, 2024
@kleonc kleonc added this to the 4.3 milestone Apr 8, 2024
@kleonc kleonc requested a review from a team as a code owner April 8, 2024 16:49
@akien-mga akien-mga merged commit ec773fd into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
@kleonc kleonc deleted the rendering-server-instance-set-transform-document-it-is-global branch April 8, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants