Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix incorrect comparison for Array const iterator #90631

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[Core] Fix incorrect comparison for Array const iterator #90631

merged 1 commit into from
Apr 13, 2024

Conversation

AThousandShips
Copy link
Member

My bad, somehow slipped through, added some tests just to be safe

@AThousandShips AThousandShips added this to the 4.3 milestone Apr 13, 2024
@AThousandShips AThousandShips requested review from a team as code owners April 13, 2024 15:32
@akien-mga akien-mga merged commit 578d937 into godotengine:master Apr 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the array_iter_fix branch April 13, 2024 16:48
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nazarwadim Nazarwadim Nazarwadim approved these changes

@zaevi zaevi zaevi approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

add_user_signal with empty array causes crash
4 participants
@AThousandShips @akien-mga @zaevi @Nazarwadim