Remove Popup's unused "panel" style
#90633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It technically breaks compat by removing something from the API. But since this something wasn't used at all, I guess it's fine. |
akien-mga
approved these changes
Apr 13, 2024
YeldhamDev
force-pushed
the
the_popup_is_not_wearing_any_panels
branch
from
c59ffb5 to
ee6f0c3
Compare
YeldhamDev
force-pushed
the
the_popup_is_not_wearing_any_panels
branch
from
ee6f0c3 to
7c75355
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a "panel" style was erroneously added to the
Popupnode in this PR: #65192. Likely a copy-paste mistake, as said style is never used by it.