Prevent crash when dropping Resource that can't load #90664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 14, 2024
Comment on lines
+1842
to
+1844
| // Resource exists, but failed to load. We need only path and name, so we can use a dummy Resource instead. | ||
| resource.instantiate(); | ||
| resource->set_path_cache(path); |
There was a problem hiding this comment.
Would it make sense to always use this approach and save a costly load? Or it's not enough for some types of resources?
There was a problem hiding this comment.
_get_dropped_resource_line() also uses resource name, which currently can't be obtained without loading the Resource. Otherwise the method could just take path string.
akien-mga
approved these changes
May 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90600