-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change update checker version source #90742
Conversation
8c025ed
to
68ced81
Compare
The page https://godotengine.org/versions.yml should serve the file needed. @KoBeWi please test it out to see if there is anything wrong/missing. |
It's a bit more work on the website side, but shouldn't we expose the data as an easier-to-parse JSON so we can simplify the logic (and third-party project managers / hubs could also use it via our JSON parser, instead of manually implementing a YAML one)? Likewise, if we include the date info, we might want to make it machine parseable instead of the current hardcoded strings that get reused as is by the blog. |
I'm fine with either, I think json is more web-friendly, so we should probably use that. Happy to make the adjustments needed, but would like to get at least specifications to generate the file with all the information required. |
The file loads fine. We could replace it with JSON, but technically parsing the file line-by-line is more efficient (with JSON you need to parse the whole file and then search for data). JSON would make the code simpler, but since it's already written, it's fine either way. As for the specs, it would be best if it was an array of dictionaries, sorted from newest to oldest. Each dictionary needs a version number and flavor/name. The download archive link can be generated from version and release notes are unused, so they don't need to be included. |
I think the release notes could be used in the future, or by other users of this file, to link directly to release notes. So I'd suggest including them. As for the download, I'd suggest including it too, in case we ever change the URLs for it. Alternatively, we could include just the download archive URL "https://godotengine.org/download/archive/" as a field in the JSON, that can be read by any user and used to compose the full URL for each version, provided we're committed to always have such URLs like "URL_BASE/4.3-dev5". |
I would muse, for further Future Proofing, it would be nice if the actual URL checked is an editor setting, kinda like how you can determine where to download the export templates in that URL? |
I made the simplest conversion and the file is now a json file: https://godotengine.org/versions.json Let me know if further changes are needed! |
Looks good! For ease of use, should we add the |
They all include the full path in the json file now 👍 |
Updated to use the new JSON. |
Thanks! |
#75916 (comment)
Don't merge until the page is actually up :D