Fix FBX and glTF when root nodes are skeleton bones #90789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
Apr 17, 2024
fire
reviewed
Apr 17, 2024
fire
approved these changes
Apr 17, 2024
Set p_scene_parent to the skeleton to guarantee BoneAttachment3D nodes are added as a child of the active skeleton. Use get_owner() to go all the way up when calculating the root node in generate_scene
lyuma
force-pushed
the
fix_skeleton_root
branch
from
871a8bc to
d370648
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects some FBX models in which "Import as skeleton bones" option is used. However, it theoretically can affect glTF or models without "Import as skeleton bone" enabled, but it would need the root of the model to be something that would generate a bone attachment. I'll try to file an issue, but I'm able to reproduce it with this suzanne model: suzanne_multimaterial.fbx.zip if the Import As Skeleton Bones is selected.
Fix two issues
After this change, such models may look like:
Note how the skeleton is immediate under the root node, and contains bone attachment children.