Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RayCast3D's debug draw transform not updating #90800

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix RayCast3D's debug draw transform not updating #90800

merged 1 commit into from
Apr 17, 2024

Conversation

ydeltastar
Copy link
Contributor

Fix a regression that RayCast3D's debug draw transform doesn't update when Debug > Visible Collision Shapes is enabled.
Fixes: #90798

@ydeltastar ydeltastar requested a review from a team as a code owner April 17, 2024 14:30
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 17, 2024
@akien-mga
Copy link
Member

Do you know roughly when that regression happened?

@ydeltastar
Copy link
Contributor Author

Do you know roughly when that regression happened?

Probably because f556d7a

@akien-mga akien-mga requested a review from smix8 April 17, 2024 14:47
@akien-mga akien-mga merged commit 61c967b into godotengine:master Apr 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@ydeltastar ydeltastar deleted the fix-raycast3d-debug-draw branch April 29, 2024 15:14
@matheusmdx matheusmdx mentioned this pull request Aug 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

RayCast3D's debug draw does not update its transform.
4 participants
@ydeltastar @akien-mga @smix8 @AThousandShips