Disable Create button for abstract classes #90807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we set a tooltip on the disabled button to explain that this class is not instantiable? |
KoBeWi
force-pushed
the
creating_this_thing_is_strictly_prohibited_in_13_states
branch
from
5df38c6
to
c940793
Compare
|
|
AThousandShips
approved these changes
Apr 17, 2024
|
Thanks! |
KoBeWi
deleted the
creating_this_thing_is_strictly_prohibited_in_13_states
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click an abstract node and then click Create, nothing happens.
This PR makes the Create button disabled, so it's clear that you are not supposed to create this node.