[Button] Fix theme elements size rounding errors not keeping sufficient space for the text. #90838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt space for the text.
akien-mga
reviewed
Apr 18, 2024
| @@ -358,7 +358,7 @@ void Button::_notification(int p_what) { | |||
| if (!xl_text.is_empty()) { | |||
| text_buf->set_alignment(align_rtl_checked); | |||
|
|
|||
| float text_buf_width = MAX(1.0f, drawable_size_remained.width); // The space's width filled by the text_buf. | |||
| float text_buf_width = Math::ceil(MAX(1.0f, drawable_size_remained.width)); // The space's width filled by the text_buf. | |||
There was a problem hiding this comment.
Should it be round() to avoid errors on the other end where 62.000000047 would become 63?
Or is it better to err on the side of caution and have one too many pixels instead of one too few?
There was a problem hiding this comment.
An extra pixel in the text buffer should not be an issue (it's setting max. width available for the string), so always ceiling is probably safer (I'm not sure how big the error can get since a lot of code is involved in control size calculations).
akien-mga
approved these changes
Apr 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90745