Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when GraphFrame sb_to_draw_panel is not a StyleBoxFlat #90874

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Zylann
Copy link
Contributor

@Zylann Zylann commented Apr 18, 2024

Fixes #88014 (review)

This was flagged by GCC as a warning treated as error on my CI (not sure why Godot CI didnt catch it?).

scene/gui/graph_frame.cpp:121:84: error: 'this' pointer is null [-Werror=nonnull]
  121 |                                         sb_panel_texture = sb_panel_flat->duplicate();
      |                                                            ~~~~~~~~~~~~~~~~~~~~~~~~^~

@Zylann Zylann requested a review from a team as a code owner April 18, 2024 20:34
@akien-mga akien-mga added this to the 4.3 milestone Apr 18, 2024
@akien-mga akien-mga changed the title Fix crash when GraphFrame sb_to_draw_panel is not a StyleBoxFlat Fix crash when GraphFrame sb_to_draw_panel is not a StyleBoxFlat Apr 18, 2024
@akien-mga akien-mga merged commit 626c6a0 into godotengine:master Apr 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants