Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect C# in OS.get_cmdline_args docs #90985

Merged

Conversation

Fulanko
Copy link
Contributor

@Fulanko Fulanko commented Apr 21, 2024

Fixes incorrect C# example for the documentation of OS.get_cmdline_args

@Fulanko Fulanko requested a review from a team as a code owner April 21, 2024 15:56
@AThousandShips AThousandShips added bug discussion cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 21, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 21, 2024
doc/classes/OS.xml Outdated Show resolved Hide resolved
doc/classes/OS.xml Show resolved Hide resolved
@AThousandShips
Copy link
Member

Please squash your commits into one, see here

@Fulanko Fulanko force-pushed the fix-class-docs-os_get_cmdline_args branch from 3acf544 to 1f32b22 Compare April 22, 2024 17:31
@Fulanko Fulanko closed this Apr 22, 2024
@Fulanko Fulanko reopened this Apr 22, 2024
@akien-mga akien-mga changed the title Fix incorrect c# in OS.get_cmdline_args Fix incorrect C# in OS.get_cmdline_args docs Apr 22, 2024
@akien-mga akien-mga merged commit b7bc667 into godotengine:master Apr 22, 2024
32 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Fulanko Fulanko deleted the fix-class-docs-os_get_cmdline_args branch April 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants