[MP] Fix disconnect_peer
not doing the proper cleanup
#91011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower layers (cache, replication) were not being notified about the peer being disconnected.
Fixes #91007 (note, there's another issue, causing a different error spam in the client, which should be fixed in a separate PR as it involves different codes).
Note: In this PR I'm preserving compatibility by not emitting the signal, I wonder if we want to change that, I see that there's some inconsistency across Godot when it comes to emitting signals in response to functions being called via code.