Make scan for projects threaded #91064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Apr 23, 2024
| @@ -61,7 +61,7 @@ void ProgressBar::_notification(int p_what) { | |||
| Size2 size = get_size(); | |||
| real_t fill_size = MIN(size.width, size.height) * 2; | |||
|
|
|||
| if (Engine::get_singleton()->is_editor_hint() && !editor_preview_indeterminate) { | |||
| if (is_part_of_edited_scene() && !editor_preview_indeterminate) { | |||
There was a problem hiding this comment.
These changes were needed to run indeterminate progress in Project Manager.
Looking at the code, I don't get how it already works in the editor (in template download).
akien-mga
approved these changes
May 29, 2024
|
Is this one still good for merging into early 4.4?) |
AThousandShips
approved these changes
Dec 7, 2024
KoBeWi
force-pushed
the
scan_everything
branch
from
6d27f8e to
c03d971
Compare
arkology
reviewed
Dec 9, 2024
KoBeWi
force-pushed
the
scan_everything
branch
from
c03d971 to
cb4ceb8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5953
godot.windows.editor.dev.x86_64_mE59gwoOhL.mp4