Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] [macOS] Build for both arm64 and x86_64 #91106

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

AThousandShips
Copy link
Member

Creates a universal build, to catch discrepancies on different architectures

Follow-up to:

See #91074 (comment)

The build times will naturally increase on large changes, but ensuring general code compliance should be worth it, using a universal build to make testing easier without having to wrangle CI commands to test which version to use

Switched back to using the latest image, can switch back to using any specific image to perhaps ensure stability, unsure if mixing images slows down CI due to needing a different runner available

@AThousandShips AThousandShips added this to the 4.x milestone Apr 24, 2024
@AThousandShips AThousandShips requested a review from a team April 24, 2024 10:50
@AThousandShips AThousandShips requested a review from a team as a code owner April 24, 2024 10:50
@AThousandShips AThousandShips changed the title [CI] [macOS] Build for both architectures [CI] [macOS] Build for both arm64 and x86_64 Apr 24, 2024
Creates a universal build, to catch discrepancies on different
architectures
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 24, 2024
@AThousandShips
Copy link
Member Author

If we experience issues with the macos-latest we can revert it back to some other version, or force it to the latest, my own repo uses the macos-14-arm64 runner and ran safely so should work either way, using a fixed version would give stability but unless required I'll leave it for now and see if something is needed down the line

@akien-mga akien-mga merged commit 7125d41 into godotengine:master Apr 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the macos_ci_improve branch April 24, 2024 17:00
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 25, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.3.
Cherry-picked for 4.1.5.
Cherry-picked for 4.0.5.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants