Use TextEdit caret color for minimap highlight (fix minimap regression) #91137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Apr 25, 2024
ckaiser
force-pushed
the
fix-minimap-lightmode
branch
from
4c70385 to
91fff47
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the minimap highlight regression mentioned in #78311, decided to use the caret color as a base since that way it's not a hardcoded value and it's consistent across themes. Originally I attempted to get the background color but the only way to get actual one was to make a
StyleBoxFlatfromStyleBoxand then get the bg_color and this seems much cleaner IMO but I might be missing something on that front.Before & After:
