-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill copyright field in .csproj files to ensure that nuget packages will have both license and copyright fields filled #91144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from a copyright/license point of view.
No idea about the .NET ecosystem integration, I'll let the team assess.
@@ -14,6 +14,8 @@ | |||
<PackageType>MSBuildSdk</PackageType> | |||
<PackageTags>MSBuildSdk</PackageTags> | |||
<PackageLicenseExpression>MIT</PackageLicenseExpression> | |||
<Copyright>Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I assume AUTHORS.md
won't be shipped together with the nuget package, I think we can change it to just:
<Copyright>Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). | |
<Copyright>Copyright (c) 2014-present Godot Engine contributors. |
That's what we do e.g. for in-engine copyright statements.
Makes sense to me although I'm not sure how I feel about using multiple-lines. Microsoft's documentation recommends the format @akien-mga How about just including |
Sounds good to me. |
@raulsntos I am not sure if we should remove personal mentions of the 2007-2014 contributors. |
Technically there's not much code from Juan and Ariel in the GodotSharp packages, so it's fine to just make it a blanket statement for all contributors. Note: I'm the main "copyright" guy so you can trust my decision on that ;) Juan and Ariel won't feel left out. |
@akien-mga So, the final decision is |
@akien-mga I have just updated the files as we agreed. |
Looks good! Could you squash the commits? See PR workflow for instructions. |
06f7edc
to
fc107ac
Compare
Done |
This ensures that nuget packages will have both license and copyright fields filled.
fc107ac
to
2b46e00
Compare
Done. I'm sorry to bother you so much. |
No worry! We're somewhat opinionated around the Git history in the Godot repo :D |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Since Godot uses the MIT license, copyright is important for the correct display of license information.
This pull request adds the copyright to the csproj files, from where it will then go into NuGet packages.
The value from the LICENSE.txt file in the root of the repository was used as the copyright: