Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-change check to Label3D::set_text #91177

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add no-change check to Label3D::set_text #91177

merged 1 commit into from
Apr 29, 2024

Conversation

markusstephanides
Copy link
Contributor

@markusstephanides markusstephanides commented Apr 25, 2024 •
edited
Loading

Improves performance by avoiding unnecessary work if text didn't change.

@markusstephanides markusstephanides requested a review from a team as a code owner April 25, 2024 20:13
@akien-mga akien-mga changed the title Add no-change check to Label3D::set_text Add no-change check to Label3D::set_text Apr 25, 2024
@akien-mga akien-mga added this to the 4.x milestone Apr 25, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 26, 2024
@akien-mga akien-mga merged commit ba27c0c into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@markusstephanides @akien-mga @Calinou