Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation typo that flipped the description of window_set_max_size and window_set_min_size #91234

Merged

Conversation

brennennen
Copy link
Contributor

doc fix typo that flipped the description of window_set_max_size and window_set_min_size

The documentation had the "smaller/larger" words in the descriptions of "window_set_max_size" and "window_set_min_size" flipped.

Old window_set_max_size description:

window_set_max_size:
Sets the maximum size of the window specified by [param window_id] in pixels. Normally, the user will not be able to drag the window to make it smaller than the specified size. See also [method window_get_max_size].

The function "window_set_max_size" sets the maximum size of the window, if you set this to 640x480, you can then not drag your window to be larger than 640x480. You can still drag your window to be smaller.

And vice versa for "window_set_max_size".

@brennennen brennennen requested a review from a team as a code owner April 27, 2024 00:25
@YeldhamDev YeldhamDev added this to the 4.3 milestone Apr 27, 2024
@fire fire changed the title doc fix typo that flipped the description of window_set_max_size and window_set_min_size Fix documention typo that flipped the description of window_set_max_size and window_set_min_size Apr 27, 2024
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
window_set_max_size and window_set_min_size
@brennennen brennennen force-pushed the doc_fix_window_set_min_size branch from 304718a to 9a28cfe Compare April 27, 2024 21:40
@akien-mga akien-mga changed the title Fix documention typo that flipped the description of window_set_max_size and window_set_min_size Fix documention typo that flipped the description of window_set_max_size and window_set_min_size Apr 29, 2024
@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 29, 2024
@akien-mga akien-mga merged commit d30e3ec into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix documention typo that flipped the description of window_set_max_size and window_set_min_size Fix documentation typo that flipped the description of window_set_max_size and window_set_min_size Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants