-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export dialog sizing issue on small devices #91291
Fix export dialog sizing issue on small devices #91291
Conversation
How do I compile this to an apk so i can use it? |
401e1d1
to
f0f98ff
Compare
The errors are not visible at all now 🙃 |
f0f98ff
to
a789983
Compare
Fixes godotengine#73130 - Update the min height from `700` to `500` to match the editor's min height of `600` - Wrap the sections of the `TabContainer` within a `ScrollContainer`. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.
a789983
to
60a4cc2
Compare
@KoBeWi I've added a min size for the file tree, so it's now visible when the dialog is resized.
I've reverted the changes to the error list; I couldn't figure out the proper configuration that would get it to both be scrollable, but expand as needed based on its parent's height. |
Thanks! |
Fixes #73130
700
to500
to match the editor's min height of600
Resources
andEncryption
sections of theTabContainer
within aScrollContainer
. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.