Store previous relative transforms in XRHandModifier3D
#91335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Apr 29, 2024
AThousandShips
approved these changes
Apr 30, 2024
devloglogan
force-pushed
the
xr-hand-modifier-update
branch
from
06ef680 to
a35196b
Compare
dsnopek
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks!
In my testing, this works perfectly, fixing the regression. (I tested with the 'godot_openxr_vendors' demo on Quest 3.)
The code looks good too! The one thing I wonder is if we should have an option to turn off this behavior or a way clear the previous data? Although, I can't fully picture the use-cases for that now, so I don't think we should hold up the PR on that.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that
XRHandModifier3Dstores the transforms of each joint on every full execution of the_process_modification()function. These transforms can then be applied ifXRHandTracker::get_has_tracking_data()returns false.After recent updates I was bumping into issues on Quest 2 / Pro where, on opening the system menu, the hand models would jarringly snap back to a resting position. With this PR, the hands will instead remain frozen in position.