Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor spin slider RTL and margin #91384

Merged
merged 1 commit into from
May 2, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented May 1, 2024

Fixes the EditorSpinSlider in rtl layout.
The up/down arrows input area was on the wrong side and the LineEdit opened to the side.

Before:
godot rtl editorspinslider issue

Fixes caret leaving the area when full:

image

@kitbdev kitbdev requested review from a team as code owners May 1, 2024 00:28
@YeldhamDev YeldhamDev added this to the 4.3 milestone May 1, 2024
@akien-mga akien-mga requested a review from bruvzg May 1, 2024 06:32
editor/gui/editor_spin_slider.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Fix editor spin slider rtl and margin Fix editor spin slider RTL and margin May 2, 2024
@kitbdev kitbdev force-pushed the fix-spin-slider-margin branch from fbb2c45 to 5fd2373 Compare May 2, 2024 12:35
@akien-mga akien-mga merged commit a531452 into godotengine:master May 2, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the fix-spin-slider-margin branch May 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants