Fix TextEdit crash with multiple carets disabled and paste #91457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeEdit.add_caret_at_caretsfunction crashes Godot #91440TextEdit.menu_optionfunction crashes Godot #91441add_caret_at_caretsnow only runs if multiple carets are enabled. Added a simple test, and a check to make sure add caret worked.menu_option(2)calls paste which used the wrong value in the for loop condition.Made sure multiple caret functionality only runs if it is enabled.
Made sure that multi caret ignore carets will only be added to if there is multiple carets, since it is to prevent overlapping carets from affecting anything.