[Core] Add case-insensitive String::containsn
#91611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
string_containsn
branch
2 times, most recently
from
131c6cc to
30dd881
Compare
AThousandShips
force-pushed
the
string_containsn
branch
from
30dd881 to
30f00d5
Compare
akien-mga
approved these changes
May 8, 2024
AThousandShips
force-pushed
the
string_containsn
branch
from
30f00d5 to
b4c6cc7
Compare
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized the potential need for this when reviewing:
ConnectDialog::_filter_method_listto be case insensitive for search string #91598There aren't extremely many cases, and not all
Stringmethods have a case-insensitive version, but I felt this one was a prime candidate.There were a few cases of
to_lower().containscases that I left alone as they already operate on a lowe-case search term so probably faster to use that formatOptionally converted some uses offindwithcontainswhere applicable, for readabilitySeparated these to their own PR
Edit: Will add exposing the method in an optional commit later today