Editor: Fix EditorHelpBitTooltip + ProgressDialog causes crash
#91716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
May 13, 2024
|
Thanks! |
dalexeev
deleted the
editor-fix-help-bit-tooltip-and-progress-dialog-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash only (?) occurs in sanitizer builds. The reason is that
ProgressDialogcallsMain::iteration()which makesqueue_free()unsafe, see #91652 (comment) for details.This is probably not the only such bug in the editor, and in the future we should reconsider the approach of calling
Main::iteration()in many places. But for now, this fix is probably the least invasive option.CC @timothyqiu @KoBeWi