Improve button min. size calculation.

[bruvzg]

Fixes #91022

Changes button min. size calculation to take into account all stiles and use the largest possible margin. _get_current_stylebox() can't be used for the min. size calculation, since min. size is not recalculated on hover.

[akien-mga]

I trust that checking all these is necessary, but how expensive is it computationally? I'm worried about how the cost might scale for button heavy UIs, like the Godot editor.

[bruvzg]

but how expensive is it computationally?

I'll check it later, but StyleBox::get_minimum_size is doing only simple math, so should not have any significant impact, unless it's custom StyleBox and _get_minimum_size is implemented in a script. And it's only used it the buttons get_minimum_size, which is only called when layout is changing.

[KoBeWi]

This looks like something that can be cached when theme/layout changes.

[bruvzg]

Moved it to theme cache.

but how expensive is it computationally?

With default theme, it takes 0-2 μs to call it.

[passivestar]

Works on my end, thanks.

P.S. There's also a problem with icons shifting in "hover-pressed". I was hoping it could be a part of the same problem as text, but this one still occurs:

Screen.Recording.mp4

[bruvzg]

There's also a problem with icons shifting in "hover-pressed". I was hoping it could be a part of the same problem as text, but this one still occurs

Probably draw should use max. style size for alignment as well.

[bruvzg]

There's also a problem with icons shifting in "hover-pressed". I was hoping it could be a part of the same problem as text, but this one still occurs

Updated to also fix this by caching the largest margins as well.

[passivestar]

Updated to also fix this by caching the largest margins as well.

It works 🎉

[akien-mga]

Thanks!