Allow selecting TileMapLayers by clicking them #92016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Jun 23, 2024
Is this caused by this PR or not ? If not, I think it's good to merge. |
|
Well this PR only adds I think it's some weird corner-case with editor input, where clicking a node starts dragging it, but the editor appears and intercepts the release event. |
|
Thanks! |
|
Is there any way to disable this behaviour? I find it pretty disruptive to my workflow in the latest beta |
|
no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TileMapLayers introduced a workflow problem where selecting a layer for editing is more difficult, depending on scene layout. A common workflow is to put TileMapLayers under a single parent. To select a layer you need to first unfold the parent, which is less convenient. If TileMapLayers are under different parents (and the new system allows for some nice setups), finding the correct layer to edit is even more difficult.
This PR allows selecting a layer by clicking it.
rceUhU87CP.mp4
Although I found a bug 🤔 When you close the bottom editor using shortcut after a layer was selected, it gets glued to the cursor.
godot.windows.editor.dev.x86_64_W0KTw5ZtLV.mp4