-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default NodePaths saved in scene #92095
Conversation
Maybe it would be good to ask @warriormaster12 to try this MR; it could help to make progress on it? That would be beneficial to prevent regression on #83343. |
I can certainly give it a look however I'm not sure if I'm going to be able to give any useful input on the matter since my understanding of the code is as much as I touched. |
Hmm the assumption that I made in However, if this only causes a cosmetic inconsistency then I don't see an issue in reverting the change. |
Pushed a solution that doesn't break reverting. |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks! |
Many thanks for the fix and review! 🙏 |
Fixes #91591
I spent whole day writing tests for both #91591 and #82670
In the end it turned out that disabling #83343, or at least part of it, fixes both issues. I don't know what to think about it, maybe I'm missing something.
Putting as draft. If it's a correct solution I assume more code needs to be removed.