Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the AudioStreamPlayer icons to be clearer. #92116

Merged
merged 1 commit into from
May 20, 2024
Merged

Change the AudioStreamPlayer icons to be clearer. #92116

merged 1 commit into from
May 20, 2024

Conversation

RadiantUwU
Copy link
Contributor

@RadiantUwU RadiantUwU requested a review from a team as a code owner May 19, 2024 11:56
@AThousandShips AThousandShips added this to the 4.x milestone May 19, 2024
@RedMser
Copy link
Contributor

RedMser commented May 19, 2024

You should optimize SVGs, use for example SVGOMG

@AThousandShips
Copy link
Member

See here for optimization instructions

@RadiantUwU @mieldepoche
Change the AudioStreamPlayer icons to be more clear.
b20d7af 
Co-authored-by: mieldepoche <mieldepoche@users.noreply.github.com>
Calinou
Calinou approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is how it looks in action:

image

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 20, 2024
@akien-mga akien-mga changed the title Change the AudioStreamPlayer icons to be more clear. Change the AudioStreamPlayer icons to be clearer. May 20, 2024
@akien-mga akien-mga merged commit 15a8887 into godotengine:master May 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RadiantUwU RadiantUwU deleted the new_audio_icons branch May 20, 2024 17:03
@AThousandShips AThousandShips mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Use a colored speaker icon for AudioStreamPlayers
5 participants
@RadiantUwU @RedMser @AThousandShips @akien-mga @Calinou