Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't translate preview in node batch rename dialog #92192

Merged
merged 1 commit into from
May 21, 2024
Merged

Don't translate preview in node batch rename dialog #92192

merged 1 commit into from
May 21, 2024

Conversation

timothyqiu
Copy link
Member

Node name rename preview was translated 😂

@timothyqiu timothyqiu added this to the 4.3 milestone May 21, 2024
@akien-mga akien-mga changed the title Don't traslate preview in node batch rename dialog Don't translate preview in node batch rename dialog May 21, 2024
akien-mga
akien-mga approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should have made the default OFF in the editor, and enabled it where we want it, instead of playing whack-a-mole with unexpected translations ;)

@akien-mga akien-mga merged commit aaa4560 into godotengine:master May 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the no-thank-you branch May 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga