Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PopupMenu focus issues after Viewport::set_embedding_subwindows is changed. #92243

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix PopupMenu focus issues after Viewport::set_embedding_subwindows is changed. #92243

merged 1 commit into from
May 23, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 22, 2024

FLAG_NO_FOCUS was set only in enter tree (in the is_embedded()) and was not updated if embedding_subwindows state is changed in runtime, causing incorrect focus handling.

@bruvzg bruvzg added this to the 4.3 milestone May 22, 2024
@bruvzg bruvzg requested a review from a team as a code owner May 22, 2024 08:31
@bruvzg bruvzg mentioned this pull request May 22, 2024
Open
@akien-mga akien-mga merged commit 55af739 into godotengine:master May 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga