Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select text in SpriteFramesEditor spin boxes on focus #92442

Merged
merged 1 commit into from
May 28, 2024

Conversation

pkowal1982
Copy link
Contributor

Current implementation of sprite frames editor does not select text on focus
which is inconvenient and inconsistent with property editor.

This small fix changes this behaviour and allows to just type values without
need of deleting previous content before.

before_sprite_frame_editor

after_sprite_frame_editor

@AThousandShips AThousandShips requested a review from a team May 27, 2024 20:20
@AThousandShips AThousandShips added this to the 4.x milestone May 27, 2024
@KoBeWi
Copy link
Member

KoBeWi commented May 27, 2024

Unrelated, but I feel like we should have select all on focus enabled in all SpinBoxes in the editor 🤔

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 28, 2024
@akien-mga akien-mga merged commit 1446722 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@pkowal1982
Copy link
Contributor Author

@akien-mga Would be nice to merge also this as it's even smaller in size and also fixes inconsistent UI behaviour.

@pkowal1982 pkowal1982 deleted the sprite_frames branch July 1, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants