Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix completion of functions with struct param/return type in shaders #92464

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix completion of functions with struct param/return type in shaders #92464

merged 1 commit into from
May 28, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 28, 2024

Fixes invalid completion:

изображение

After:

изображение

Also, I've decided to rename internal variable 'type_str' to 'struct_name' for better consistency with other code.

@Chaosus Chaosus requested a review from a team as a code owner May 28, 2024 09:16
@Chaosus Chaosus added this to the 4.3 milestone May 28, 2024
@akien-mga akien-mga merged commit 86872f3 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_fix_struct_completion branch May 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga