Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error after create a new animation in an empty AnimationPlayer #92495

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix error after create a new animation in an empty AnimationPlayer #92495

merged 1 commit into from
May 29, 2024

Conversation

matheusmdx
Copy link
Contributor

Fix #92471

@matheusmdx matheusmdx force-pushed the fix-animation-player-error branch from 4af9aac to bb67f8d Compare May 28, 2024 22:08
@akien-mga akien-mga requested a review from lyuma May 28, 2024 22:12
@akien-mga akien-mga added this to the 4.3 milestone May 28, 2024
@akien-mga akien-mga requested a review from TokageItLab May 28, 2024 22:13
@akien-mga
Copy link
Member

There are some style issues (trailing whitespace on empty lines).

@matheusmdx matheusmdx force-pushed the fix-animation-player-error branch from bb67f8d to 18cdb3c Compare May 28, 2024 22:14
passivestar
passivestar approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@passivestar passivestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected, code makes sense

@akien-mga akien-mga merged commit a8cc65f into godotengine:master May 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@matheusmdx matheusmdx deleted the fix-animation-player-error branch May 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TokageItLab TokageItLab TokageItLab approved these changes

@passivestar passivestar passivestar approved these changes

@lyuma lyuma Awaiting requested review from lyuma

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

"Animation not found" error message when creating the first animation in the animation editor
4 participants
@matheusmdx @akien-mga @passivestar @TokageItLab