Fix huge .tscn icon and icon in background of File System panel #92669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Icon position is wrong in RTL mode, because its calculated with unscaled texture size: |
Hilderin
force-pushed
the
fix-huge-tscn-icon-in-background-of-file-system-panel
branch
from
f9a72d2
to
81395cf
Compare
|
Good point... Fixed it: |
KoBeWi
approved these changes
Jun 2, 2024
akien-mga
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92646
The problem was caused by a custom tag icon of the scene in the FileSystemDock
ItemList. It was not possible to set a size for tag icons inItemList, so I added the methodset_fixed_tag_icon_sizeand called it in FileSystemDock.Was able to reproduce and test with this project:
test-godot-cloud-icon.zip
I guess the black square comes from the blank scene:
