Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix 32-bit MinGW LTO build. #92753

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[Windows] Fix 32-bit MinGW LTO build. #92753

merged 1 commit into from
Jun 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 4, 2024

Fixes #92585, seems like _register_variant_builtin_methods simply grown too big for 32-bit LTO, splitting it into multiple functions fix the issue.

@bruvzg bruvzg added this to the 4.3 milestone Jun 4, 2024
@bruvzg bruvzg requested a review from a team as a code owner June 4, 2024 10:47
AThousandShips
AThousandShips approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a feeling this was the cause but didn't end up testing it out myself as a solution

@akien-mga akien-mga merged commit 96a386f into godotengine:master Jun 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

MinGW-GCC internal compiler error on Windows x86_32 with LTO enabled
3 participants
@bruvzg @akien-mga @AThousandShips