Set XRHandTracker property has_tracking_data to true only when palm joint is tracked
#92801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devloglogan
changed the title
XRHandTracker property has_tracking_data to true only when palm joint is trackedXRHandTracker property has_tracking_data to true only when palm joint is tracked
devloglogan
force-pushed
the
has-tracking-data-fix
branch
from
1ff30f5
to
a64b0d3
Compare
dsnopek
approved these changes
Jun 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when calling
get_has_tracking_data()on anXRHandTracker, it will always return true. This update sets that value to false if the palm joint is not being tracked. It also invalidates the pose of the tracker, making it so theXRNode3Dpropertyshow_when_trackedworks as expected (e.g. hiding hand tracked meshes when hands aren't visible).