Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset the owner of ImporterMeshInstance3D before adding it to skeleton's child #93117

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Unset the owner of ImporterMeshInstance3D before adding it to skeleton's child #93117

merged 1 commit into from
Jun 13, 2024

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Jun 13, 2024 •
edited
Loading

Fixes #93092

Tested locally it doesn't seem to break the import functionality.

@jsjtxietian jsjtxietian requested a review from a team as a code owner June 13, 2024 04:46
@Chaosus Chaosus added this to the 4.3 milestone Jun 13, 2024
@akien-mga akien-mga requested review from fire and aaronfranke June 13, 2024 07:44
akien-mga
akien-mga approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@AThousandShips AThousandShips changed the title Unsetting the owner of ImporterMeshInstance3D before adding it to skeleton's child Unset the owner of ImporterMeshInstance3D before adding it to skeleton's child Jun 13, 2024
@akien-mga akien-mga merged commit fc499fc into godotengine:master Jun 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the gltf-owner branch June 13, 2024 09:54
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire Awaiting requested review from fire

@aaronfranke aaronfranke Awaiting requested review from aaronfranke

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:import topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

A warning emits at opening any GLTF animated model
3 participants
@jsjtxietian @akien-mga @Chaosus