Update signal connections in CanvasLayer::set_custom_viewport
#93167
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CanvasLayer connects/disconnects the "child_order_changed" signal from its parent to its viewport when entering/exiting the tree. This signal wasn't being updated when changing the viewport in set_custom_viewport, causing errors when trying to disconnect a different viewport. This change updates the signal connections when changing the viewport. Fixes the disconnect error in godotengine#90141
akien-mga
added
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanvasLayerconnects/disconnects the "child_order_changed" signal from its parent to its viewport when entering/exiting the tree. This signal wasn't being updated when changing the viewport inset_custom_viewport, causing errors when trying to disconnect a different viewport. This change updates the signal connections when changing the viewport.Fixes the disconnect error in #90141
Note: the linked issue also mentions some Vulkan errors, which only appear in the larger project but not the MRP. This seems separate from the signal disconnect error. It looks like the Vulkan code has changed a lot since then (I don't see those error messages in the code, or even the .cpp file that had them), so that part might already be fixed, maybe related to #71929.