Add missing style overrides for viewport overlay buttons #93361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passivestar
commented
Jun 19, 2024
| surface->add_child(cinema_label); | ||
| cinema_label->set_text(TTR("Cinematic Preview")); | ||
| cinema_label->hide(); | ||
| previewing_cinema = false; | ||
|
|
||
| locked_label = memnew(Label); | ||
| locked_label->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER); | ||
| locked_label->set_vertical_alignment(VERTICAL_ALIGNMENT_CENTER); |
passivestar
commented
Jun 19, 2024
Comment on lines
-1785
to
-1789
| // 2D/CanvasItem editor | ||
| Ref<StyleBoxFlat> style_canvas_editor_info = make_flat_stylebox(Color(0.0, 0.0, 0.0, 0.2)); | ||
| style_canvas_editor_info->set_expand_margin_all(4 * EDSCALE); | ||
| p_theme->set_stylebox("CanvasItemInfoOverlay", EditorStringName(EditorStyles), style_canvas_editor_info); | ||
|
|
There was a problem hiding this comment.
This appears to be unused since 030697e#diff-eb4ce61def40bf37d0fba218d92fa230c11f78e3a56f2849cdfe0045512acc3bL3923
KoBeWi
reviewed
Jun 20, 2024
KoBeWi
approved these changes
Jun 20, 2024
passivestar
force-pushed
the
viewport-buttons-styles
branch
from
54d285c to
8307871
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewport overlay buttons were missing styles which made them look broken in "hover-pressed" state and in RTL when using a custom theme
Note: this doesn't expose those overrides to theming and just using the same overlay stylebox for all states (just like the already existing overrides), because for now I want to avoid adding 11 styleboxes to
EditorStyles. We can get back to this later when the situation with theme categories is figured out