[LLVM/MinGW] Fix/suppress DX12 related warnings. #93369
Conversation
| #elif defined(__clang__) | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wnon-virtual-dtor" | ||
| #pragma clang diagnostic ignored "-Wstring-plus-int" | ||
| #pragma clang diagnostic ignored "-Wswitch" | ||
| #pragma clang diagnostic ignored "-Wmissing-field-initializers" |
There was a problem hiding this comment.
I believe Clang honors #pragma GCC diagnostic too, so as long as the warnings to ignore are the same, we could maybe just remove the !defined(__clang__) part in the first block and avoid the redundancy.
There was a problem hiding this comment.
Well I see there's already a difference with -Wshadow on GCC and -Wstring-plus-int on Clang, so maybe not worth it.
There was a problem hiding this comment.
Another option for Clang would be to ignore all warnings:
#pragma clang diagnostic ignored "-Wall"
#pragma clang diagnostic ignored "-Wextra"GCC doesn't seem to support that so it still needs each specific warning listed manually.
There was a problem hiding this comment.
Since it is for DX headers we might as well suppress everything, I'll check if it works like this a bit later.
There was a problem hiding this comment.
Another option for Clang would be to ignore all warnings
It doesn't work (at least not for all warnings).
| @@ -6635,7 +6638,7 @@ Error RenderingDeviceDriverD3D12::_initialize_frames(uint32_t p_frame_count) { | |||
| D3D12MA::ALLOCATION_DESC allocation_desc = {}; | |||
| allocation_desc.HeapType = D3D12_HEAP_TYPE_DEFAULT; | |||
|
|
|||
| CD3DX12_RESOURCE_DESC resource_desc = CD3DX12_RESOURCE_DESC::Buffer(D3D12_CONSTANT_BUFFER_DATA_PLACEMENT_ALIGNMENT); | |||
| //CD3DX12_RESOURCE_DESC resource_desc = CD3DX12_RESOURCE_DESC::Buffer(D3D12_CONSTANT_BUFFER_DATA_PLACEMENT_ALIGNMENT); | |||
There was a problem hiding this comment.
Should this be outright removed if it's unused?
There was a problem hiding this comment.
It is unused, but I have not removed it since I'm not sure if something was planned to use it in the future or it's completely pointless.
| @@ -1462,7 +1465,7 @@ RDD::TextureID RenderingDeviceDriverD3D12::_texture_create_shared_from_slice(Tex | |||
| uav_desc.Format = RD_TO_D3D12_FORMAT[p_view.format].general_format; | |||
| } | |||
|
|
|||
| if (p_slice_type != -1) { | |||
| if (p_slice_type != (TextureSliceType)-1) { | |||
There was a problem hiding this comment.
Isn't there a compiler flag or something else global that allows these?
There was a problem hiding this comment.
Yes, but why? This is a valid warning and might point to the real issue with integer ranges.
|
Thanks! |
Fixes LLVM warnings in the DX12 driver code, and suppressed LLVM warnings in third-party headers.