-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browse_dialog
in Blender scene importer to accept files
#93411
Conversation
browse_dialog
in Blender scene importer to accept files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
However, the UI still refers to a Blender installation, which can be a bit ambiguous. I suggest renaming it to Blender executable instead.
On macOS, it might be worth hinting that you should point at Contents/MacOS/blender
within Blender.app
too (e.g. by appending to the label with #ifdef MACOS_ENABLED
).
I could change "installation" to "executable". However, for Mac support, it would be better for someone else handle that, as I have never touched a Mac let along program one. |
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
3188d62
to
344ff6f
Compare
I pushed an update myself that adjusts the label and error messages for clarity. |
For the record, I noticed #94914 while working on this, but it doesn't seem related to these changes, the bug also happens in RC 1. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Changes EditorFileSystemImportFormatSupportQueryBlend::browse_dialog to accept file names. As it is now, it only accepts directory names. This will present an error as the callback "_select_install" and subsequent calls to "_validate_path" and "_get_blender_version" are all expecting filenames.
Closes #93235