Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix lost old callback when continuous call requestRenderAndNotify #93571

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Alex2782
Copy link
Contributor

I have run git diff, the file is identical to master branch.
Tested on MacOS and Android Adreno 6xx with GLES 3.0

@m4gr3d m4gr3d requested a review from lawnjelly July 18, 2024 00:15
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Jul 18, 2024
@akien-mga akien-mga changed the title [3.x] fix lost old callback when continuous call requestRenderAndNotify [3.x] Fix lost old callback when continuous call requestRenderAndNotify Jul 18, 2024
@lawnjelly
Copy link
Member

lawnjelly commented Jul 18, 2024

Note this is backported from #87352 . (This is useful to include in the notes as it makes it easier to review / crossreference).

Will trust m4gr3d on this as I'm not familiar with this area, and it seems to have been merged in master for 5 months so must have been tested to a reasonable extent.

@lawnjelly lawnjelly merged commit 9a6b424 into godotengine:3.x Jul 18, 2024
14 checks passed
@lawnjelly
Copy link
Member

Thanks!

@Alex2782
Copy link
Contributor Author

Alex2782 commented Jul 18, 2024

Thanks for the advice!

I wanted to separate it, Godot uses its own version of the file GLSurfaceView.java (not Android API / Lib). Unfortunately I could not yet identify why Adreno 3xx does not work with GLES3 - Godot 3.x. With GLES2 there are no problems.


GLSurfaceView.java Logs on Google Git (android.googlesource.com), now 1 year, 9 months ago
I think users would normally only receive this bugfix from Android 13 onwards. After 2 years there are no more updates on Android.

@Alex2782 Alex2782 deleted the g3.x_fix_GLSurfaceView branch July 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants