Fix editor crash when invalid global class script path #93575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 25, 2024
Hilderin
force-pushed
the
fix-editor-crash-on-invalid-global-class-path
branch
from
ce69690 to
e18db6f
Compare
aaronfranke
approved these changes
Jun 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93410
Even I was not able to reproduce the problem of editor crashing on opening a script in an external editor, this PR should prevent the editor crash when the
global_script_class_cache.cfgcontains an invalid path.The PR #92303 should also fix this problem because it removes the invalid global class name at startup but I think adding this validation was an easy fix that could prevent other crashes.
The problem:
